This repository has been archived by the owner on Feb 28, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Add CAPTCHA to Stripe payment processing #111
Open
ghost
wants to merge
8
commits into
noisebridge:master
Choose a base branch
from
unknown repository
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails requires that a version specification for all migration files.
You will need to run the database migrations on the production servers ``` rake db:migrate ```
Tagging some potential reviewers: @danhimalplanet @SuperQ @lazzarello ~ Don't have access to the prod server or Travis. It could be the new server packages required for the CAPTCHA generation (ghostscript / imagemagick) or the migration failing? Couldn't find a great debug output in the Travis UI. |
We have not migrated off ratchet yet, which means we need @SuperQ to deploy
all this.
$ nslookup donate.noisebridge.net
Server: 10.20.0.1
Address: 10.20.0.1#53
Non-authoritative answer:
donate.noisebridge.net canonical name = ratchet.noisebridge.net.
ratchet.noisebridge.net canonical name = ratchet.patrickod.com.
Name: *ratchet.patrickod.com <http://ratchet.patrickod.com>*
Address: 198.199.94.57
…On Wed, May 22, 2019 at 5:20 PM Ruth Grace Wong ***@***.***> wrote:
I am for this change! But it looks like there are missing environment
variables causing the build to fail. Is this because it was migrated off of
ratchet? (maybe you know, @SuperQ <https://github.com/SuperQ> @rizend
<https://github.com/rizend> or @marcidy <https://github.com/marcidy> ?)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#111?email_source=notifications&email_token=ABMTCQC3DRMG5KX2QZAYGH3PWXPLNA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAWZYY#issuecomment-495021283>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMTCQFJBLCBFSUB54ERL43PWXPLNANCNFSM4HOYRP6A>
.
|
Isn't it due to be decomissioned very soon by Patrick? (reference:
https://noisebridge.slack.com/archives/C02A1V2PY/p1555895295019000)
He said May 21.
On Wed, May 22, 2019 at 5:44 PM Matt Arcidy <[email protected]>
wrote:
… We have not migrated off ratchet yet, which means we need @SuperQ to deploy
all this.
$ nslookup donate.noisebridge.net
Server: 10.20.0.1
Address: 10.20.0.1#53
Non-authoritative answer:
donate.noisebridge.net canonical name = ratchet.noisebridge.net.
ratchet.noisebridge.net canonical name = ratchet.patrickod.com.
Name: *ratchet.patrickod.com <http://ratchet.patrickod.com>*
Address: 198.199.94.57
On Wed, May 22, 2019 at 5:20 PM Ruth Grace Wong ***@***.***>
wrote:
> I am for this change! But it looks like there are missing environment
> variables causing the build to fail. Is this because it was migrated off
of
> ratchet? (maybe you know, @SuperQ <https://github.com/SuperQ> @rizend
> <https://github.com/rizend> or @marcidy <https://github.com/marcidy> ?)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#111?email_source=notifications&email_token=ABMTCQC3DRMG5KX2QZAYGH3PWXPLNA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAWZYY#issuecomment-495021283
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ABMTCQFJBLCBFSUB54ERL43PWXPLNANCNFSM4HOYRP6A
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#111?email_source=notifications&email_token=ABOJXTAMDE5SBZG376BVC5LPWXSHDA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAX2DI#issuecomment-495025421>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABOJXTG5HQC3MCJWQVB526DPWXSHDANCNFSM4HOYRP6A>
.
|
nslookup says what's the domain is pointing to right now. you can run it
online or from a terminal to see.
On Wed, May 22, 2019, 20:37 Ruth Grace Wong <[email protected]>
wrote:
… Isn't it due to be decomissioned very soon by Patrick? (reference:
https://noisebridge.slack.com/archives/C02A1V2PY/p1555895295019000)
He said May 21.
On Wed, May 22, 2019 at 5:44 PM Matt Arcidy ***@***.***>
wrote:
> We have not migrated off ratchet yet, which means we need @SuperQ to
deploy
> all this.
>
> $ nslookup donate.noisebridge.net
> Server: 10.20.0.1
> Address: 10.20.0.1#53
>
> Non-authoritative answer:
> donate.noisebridge.net canonical name = ratchet.noisebridge.net.
> ratchet.noisebridge.net canonical name = ratchet.patrickod.com.
> Name: *ratchet.patrickod.com <http://ratchet.patrickod.com>*
> Address: 198.199.94.57
>
>
> On Wed, May 22, 2019 at 5:20 PM Ruth Grace Wong <
***@***.***>
> wrote:
>
> > I am for this change! But it looks like there are missing environment
> > variables causing the build to fail. Is this because it was migrated
off
> of
> > ratchet? (maybe you know, @SuperQ <https://github.com/SuperQ> @rizend
> > <https://github.com/rizend> or @marcidy <https://github.com/marcidy>
?)
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
>
#111?email_source=notifications&email_token=ABMTCQC3DRMG5KX2QZAYGH3PWXPLNA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAWZYY#issuecomment-495021283
> >,
> > or mute the thread
> > <
>
https://github.com/notifications/unsubscribe-auth/ABMTCQFJBLCBFSUB54ERL43PWXPLNANCNFSM4HOYRP6A
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#111?email_source=notifications&email_token=ABOJXTAMDE5SBZG376BVC5LPWXSHDA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAX2DI#issuecomment-495025421
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ABOJXTG5HQC3MCJWQVB526DPWXSHDANCNFSM4HOYRP6A
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#111?email_source=notifications&email_token=ABMTCQCZNSXYLQCJYWNBRKDPWYGPBA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWA7DMI#issuecomment-495055281>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMTCQAL7SXH2V2BSUKYSILPWYGPBANCNFSM4HOYRP6A>
.
|
sorry I don't know ow if that came off harsh. it was meant to be straight
factual.
http://www.kloth.net/services/nslookup.php
if you put into donate.noisebridge.net as the domain and 8.8.8.8 for DNS,
it will show you where Google name server sends the packets for donate.
(8.8.8.8 is Google's DNS)
…On Wed, May 22, 2019, 22:22 Matt Arcidy ***@***.***> wrote:
nslookup says what's the domain is pointing to right now. you can run it
online or from a terminal to see.
On Wed, May 22, 2019, 20:37 Ruth Grace Wong ***@***.***>
wrote:
> Isn't it due to be decomissioned very soon by Patrick? (reference:
> https://noisebridge.slack.com/archives/C02A1V2PY/p1555895295019000)
> He said May 21.
>
> On Wed, May 22, 2019 at 5:44 PM Matt Arcidy ***@***.***>
> wrote:
>
> > We have not migrated off ratchet yet, which means we need @SuperQ to
> deploy
> > all this.
> >
> > $ nslookup donate.noisebridge.net
> > Server: 10.20.0.1
> > Address: 10.20.0.1#53
> >
> > Non-authoritative answer:
> > donate.noisebridge.net canonical name = ratchet.noisebridge.net.
> > ratchet.noisebridge.net canonical name = ratchet.patrickod.com.
> > Name: *ratchet.patrickod.com <http://ratchet.patrickod.com>*
> > Address: 198.199.94.57
> >
> >
> > On Wed, May 22, 2019 at 5:20 PM Ruth Grace Wong <
> ***@***.***>
> > wrote:
> >
> > > I am for this change! But it looks like there are missing environment
> > > variables causing the build to fail. Is this because it was migrated
> off
> > of
> > > ratchet? (maybe you know, @SuperQ <https://github.com/SuperQ> @rizend
> > > <https://github.com/rizend> or @marcidy <https://github.com/marcidy>
> ?)
> > >
> > > —
> > > You are receiving this because you were mentioned.
> > > Reply to this email directly, view it on GitHub
> > > <
> >
> #111?email_source=notifications&email_token=ABMTCQC3DRMG5KX2QZAYGH3PWXPLNA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAWZYY#issuecomment-495021283
> > >,
> > > or mute the thread
> > > <
> >
> https://github.com/notifications/unsubscribe-auth/ABMTCQFJBLCBFSUB54ERL43PWXPLNANCNFSM4HOYRP6A
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <
> #111?email_source=notifications&email_token=ABOJXTAMDE5SBZG376BVC5LPWXSHDA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAX2DI#issuecomment-495025421
> >,
> > or mute the thread
> > <
> https://github.com/notifications/unsubscribe-auth/ABOJXTG5HQC3MCJWQVB526DPWXSHDANCNFSM4HOYRP6A
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#111?email_source=notifications&email_token=ABMTCQCZNSXYLQCJYWNBRKDPWYGPBA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWA7DMI#issuecomment-495055281>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABMTCQAL7SXH2V2BSUKYSILPWYGPBANCNFSM4HOYRP6A>
> .
>
|
I opened two Issues, one on donate repo, one on infrastructure.
we would like issues to be raised for things so ppl can scroll through and
see history. the pr doesn't technically need one, but I created one
anyways. But this is just for the merge.
I added one on the infrastructure repo to deploy. all deployment goes
through the infra repo through ansible.
Deployment is mildly permissioned. deployment to some machines can be done
by anyone. critical infra like website, donate, etc cannot be done by
everyone.
just letting you know how things go,no action items. I should write this
up in more detail and disseminate it.
…On Wed, May 22, 2019, 22:29 Matt Arcidy ***@***.***> wrote:
sorry I don't know ow if that came off harsh. it was meant to be straight
factual.
http://www.kloth.net/services/nslookup.php
if you put into donate.noisebridge.net as the domain and 8.8.8.8 for DNS,
it will show you where Google name server sends the packets for donate.
(8.8.8.8 is Google's DNS)
On Wed, May 22, 2019, 22:22 Matt Arcidy ***@***.***> wrote:
> nslookup says what's the domain is pointing to right now. you can run it
> online or from a terminal to see.
>
> On Wed, May 22, 2019, 20:37 Ruth Grace Wong ***@***.***>
> wrote:
>
>> Isn't it due to be decomissioned very soon by Patrick? (reference:
>> https://noisebridge.slack.com/archives/C02A1V2PY/p1555895295019000)
>> He said May 21.
>>
>> On Wed, May 22, 2019 at 5:44 PM Matt Arcidy ***@***.***>
>> wrote:
>>
>> > We have not migrated off ratchet yet, which means we need @SuperQ to
>> deploy
>> > all this.
>> >
>> > $ nslookup donate.noisebridge.net
>> > Server: 10.20.0.1
>> > Address: 10.20.0.1#53
>> >
>> > Non-authoritative answer:
>> > donate.noisebridge.net canonical name = ratchet.noisebridge.net.
>> > ratchet.noisebridge.net canonical name = ratchet.patrickod.com.
>> > Name: *ratchet.patrickod.com <http://ratchet.patrickod.com>*
>> > Address: 198.199.94.57
>> >
>> >
>> > On Wed, May 22, 2019 at 5:20 PM Ruth Grace Wong <
>> ***@***.***>
>> > wrote:
>> >
>> > > I am for this change! But it looks like there are missing environment
>> > > variables causing the build to fail. Is this because it was migrated
>> off
>> > of
>> > > ratchet? (maybe you know, @SuperQ <https://github.com/SuperQ>
>> @rizend
>> > > <https://github.com/rizend> or @marcidy <https://github.com/marcidy>
>> ?)
>> > >
>> > > —
>> > > You are receiving this because you were mentioned.
>> > > Reply to this email directly, view it on GitHub
>> > > <
>> >
>> #111?email_source=notifications&email_token=ABMTCQC3DRMG5KX2QZAYGH3PWXPLNA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAWZYY#issuecomment-495021283
>> > >,
>> > > or mute the thread
>> > > <
>> >
>> https://github.com/notifications/unsubscribe-auth/ABMTCQFJBLCBFSUB54ERL43PWXPLNANCNFSM4HOYRP6A
>> > >
>> > > .
>> > >
>> >
>> > —
>> > You are receiving this because you commented.
>> > Reply to this email directly, view it on GitHub
>> > <
>> #111?email_source=notifications&email_token=ABOJXTAMDE5SBZG376BVC5LPWXSHDA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAX2DI#issuecomment-495025421
>> >,
>> > or mute the thread
>> > <
>> https://github.com/notifications/unsubscribe-auth/ABOJXTG5HQC3MCJWQVB526DPWXSHDANCNFSM4HOYRP6A
>> >
>> > .
>> >
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#111?email_source=notifications&email_token=ABMTCQCZNSXYLQCJYWNBRKDPWYGPBA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWA7DMI#issuecomment-495055281>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/ABMTCQAL7SXH2V2BSUKYSILPWYGPBANCNFSM4HOYRP6A>
>> .
>>
>
|
Thanks Matt for documenting issues! Sorry, haven't had a chance to take a
closer look.
…On Thu, May 23, 2019, 10:30 AM Matt Arcidy ***@***.***> wrote:
I opened two Issues, one on donate repo, one on infrastructure.
we would like issues to be raised for things so ppl can scroll through and
see history. the pr doesn't technically need one, but I created one
anyways. But this is just for the merge.
I added one on the infrastructure repo to deploy. all deployment goes
through the infra repo through ansible.
Deployment is mildly permissioned. deployment to some machines can be done
by anyone. critical infra like website, donate, etc cannot be done by
everyone.
just letting you know how things go,no action items. I should write this
up in more detail and disseminate it.
On Wed, May 22, 2019, 22:29 Matt Arcidy ***@***.***> wrote:
> sorry I don't know ow if that came off harsh. it was meant to be straight
> factual.
>
> http://www.kloth.net/services/nslookup.php
>
> if you put into donate.noisebridge.net as the domain and 8.8.8.8 for
DNS,
> it will show you where Google name server sends the packets for donate.
> (8.8.8.8 is Google's DNS)
>
> On Wed, May 22, 2019, 22:22 Matt Arcidy ***@***.***> wrote:
>
>> nslookup says what's the domain is pointing to right now. you can run it
>> online or from a terminal to see.
>>
>> On Wed, May 22, 2019, 20:37 Ruth Grace Wong ***@***.***>
>> wrote:
>>
>>> Isn't it due to be decomissioned very soon by Patrick? (reference:
>>> https://noisebridge.slack.com/archives/C02A1V2PY/p1555895295019000)
>>> He said May 21.
>>>
>>> On Wed, May 22, 2019 at 5:44 PM Matt Arcidy ***@***.***>
>>> wrote:
>>>
>>> > We have not migrated off ratchet yet, which means we need @SuperQ to
>>> deploy
>>> > all this.
>>> >
>>> > $ nslookup donate.noisebridge.net
>>> > Server: 10.20.0.1
>>> > Address: 10.20.0.1#53
>>> >
>>> > Non-authoritative answer:
>>> > donate.noisebridge.net canonical name = ratchet.noisebridge.net.
>>> > ratchet.noisebridge.net canonical name = ratchet.patrickod.com.
>>> > Name: *ratchet.patrickod.com <http://ratchet.patrickod.com>*
>>> > Address: 198.199.94.57
>>> >
>>> >
>>> > On Wed, May 22, 2019 at 5:20 PM Ruth Grace Wong <
>>> ***@***.***>
>>> > wrote:
>>> >
>>> > > I am for this change! But it looks like there are missing
environment
>>> > > variables causing the build to fail. Is this because it was
migrated
>>> off
>>> > of
>>> > > ratchet? (maybe you know, @SuperQ <https://github.com/SuperQ>
>>> @rizend
>>> > > <https://github.com/rizend> or @marcidy <
https://github.com/marcidy>
>>> ?)
>>> > >
>>> > > —
>>> > > You are receiving this because you were mentioned.
>>> > > Reply to this email directly, view it on GitHub
>>> > > <
>>> >
>>>
#111?email_source=notifications&email_token=ABMTCQC3DRMG5KX2QZAYGH3PWXPLNA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAWZYY#issuecomment-495021283
>>> > >,
>>> > > or mute the thread
>>> > > <
>>> >
>>>
https://github.com/notifications/unsubscribe-auth/ABMTCQFJBLCBFSUB54ERL43PWXPLNANCNFSM4HOYRP6A
>>> > >
>>> > > .
>>> > >
>>> >
>>> > —
>>> > You are receiving this because you commented.
>>> > Reply to this email directly, view it on GitHub
>>> > <
>>>
#111?email_source=notifications&email_token=ABOJXTAMDE5SBZG376BVC5LPWXSHDA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAX2DI#issuecomment-495025421
>>> >,
>>> > or mute the thread
>>> > <
>>>
https://github.com/notifications/unsubscribe-auth/ABOJXTG5HQC3MCJWQVB526DPWXSHDANCNFSM4HOYRP6A
>>> >
>>> > .
>>> >
>>>
>>> —
>>> You are receiving this because you were mentioned.
>>> Reply to this email directly, view it on GitHub
>>> <
#111?email_source=notifications&email_token=ABMTCQCZNSXYLQCJYWNBRKDPWYGPBA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWA7DMI#issuecomment-495055281
>,
>>> or mute the thread
>>> <
https://github.com/notifications/unsubscribe-auth/ABMTCQAL7SXH2V2BSUKYSILPWYGPBANCNFSM4HOYRP6A
>
>>> .
>>>
>>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#111?email_source=notifications&email_token=ABOJXTFZVEZLCVXUG3HN3S3PW3IDHA5CNFSM4HOYRP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWC5YUA#issuecomment-495311952>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABOJXTCG7AJDONN3MEVMRS3PW3IDHANCNFSM4HOYRP6A>
.
|
Thanks for participating in this PR @marcidy & @ruthgrace --- I'm on other code bases till Monday, but if there's anything minor feel free to ping me / add commits to this PR / make a new PR based on this one / whateva. Seems like infrastructure woes at this point. Best of luck! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: https://discuss.noisebridge.info/t/weird-activity-on-stripe/836
. . .
Things to get this working:
apt-get install ghostscript
(or whatever package manager on prod)apt-get install imagemagick
(or whatever package manager on prod)rake db:migrate
That should be it?
I don't know Ruby / Rails all that well, but code and the above steps worked on my Ubuntu server ™
. . .
EDIT: Additional info:
I've opted to go for a "simple captcha" using an image (vs Google's reCAPTCHA) for the sake of speed getting this out & not having to go through Google.
Screen cap of the new simple CAPTCHA: